Add custom camera controller #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
reviewed
Oct 20, 2023
| @@ -60,6 +60,45 @@ class ROrbitCameraController | |||
| using Qt3DExtras::QOrbitCameraController::QOrbitCameraController; | |||
| }; /* end class ROrbitCameraController */ | |||
|
|
|||
| class RCustomCameraController | |||
There was a problem hiding this comment.
Even though this is prototype code, we may use a descriptive name for the class. What name would be informative?
There was a problem hiding this comment.
hmm, I don't know, I think it depends on the behavior of the camera? like orbital or FPS
There was a problem hiding this comment.
How would you like the camera to behave (move)?
I've never wrote unit tests for UI, maybe try pytest-qt? |
If it does not take a lot of time (like more than 4 hours), it is a good idea to give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #70, the current camera control needs improvement. This pull request aims to create our own camera controller class derived from
QAbstractCameraControllerto better suit our requirements. At this point, the code introduces a new camera controller to the menu, which functions in the same way as theRFirstPersonCameraController. Further discussion is needed to determinte which functions should be added to the controller.